Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prometheus] Make instrumentation scope as identifying #4223

Open
pellared opened this issue Sep 24, 2024 · 2 comments
Open

[Prometheus] Make instrumentation scope as identifying #4223

pellared opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels
spec:metrics Related to the specification/metrics directory

Comments

@pellared
Copy link
Member

I think this needs updates to some of the compatibility docs (at least prometheus). Currently, Prometheus adds scope name and scope version as labels to ensure we don't end up with duplicate timeseries, and we are able to put scope attributes in a separate otel_scope_info metric. With this change, we will need to update this to instead add the scope name, scope version, and scope attributes to all metrics.

TIL schema_url is also identifying, so that is something we will need to handle in Prometheus export and other "non-OTLP" compatibility documents.

Originally posted by @dashpole in #4161 (comment)

@pellared pellared added the spec:metrics Related to the specification/metrics directory label Sep 24, 2024
@pellared
Copy link
Member Author

@dashpole, are you able to take this?

@dashpole
Copy link
Contributor

cc @open-telemetry/wg-prometheus

Yes, I'll take this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

No branches or pull requests

2 participants