Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit Event and event.name attribute ambiguity #4233

Closed
pellared opened this issue Sep 30, 2024 · 1 comment
Closed

Emit Event and event.name attribute ambiguity #4233

pellared opened this issue Sep 30, 2024 · 1 comment
Labels
area:api Cross language API specification issue spec:logs Related to the specification/logs directory

Comments

@pellared
Copy link
Member

Another problem, I see in defining Emit an Event method (in scope of this PR) is that there would be an ambiguity what should happen if a user adds an additional event.name attribute. Should the name parameter or event.name attribute have precedence?

PS. The same problem currently exists in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/event-api.md#emit-event

Originally posted by @pellared in #4225 (comment)

@pellared pellared added area:api Cross language API specification issue spec:logs Related to the specification/logs directory labels Sep 30, 2024
@jack-berg
Copy link
Member

PS. The same problem currently exists in https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/event-api.md#emit-event

https://github.com/open-telemetry/opentelemetry-specification/blame/fbaf8468c599d858df515c88bac58d02c9afdb29/specification/logs/event-sdk.md#L86-L89

The Name MUST be used to set the event.name Attribute. If the Attributes provided by the user contain an event.name attribute the value provided in the Name takes precedence.

@pellared pellared closed this as not planned Won't fix, can't repro, duplicate, stale Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:api Cross language API specification issue spec:logs Related to the specification/logs directory
Projects
None yet
Development

No branches or pull requests

2 participants