Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[entities] Do we allow different identifying attributes? #4253

Open
dmitryax opened this issue Oct 10, 2024 · 0 comments
Open

[entities] Do we allow different identifying attributes? #4253

dmitryax opened this issue Oct 10, 2024 · 0 comments
Labels
entities sig-issue A specific SIG should look into this before discussing at the spec

Comments

@dmitryax
Copy link
Member

dmitryax commented Oct 10, 2024

After prototyping entity detection in the collector open-telemetry/opentelemetry-collector-contrib#35538, we found that some detectors currently cannot provide the same set of identifying attributes for the same type. For example, most of the detectors detecting a host entity type can provide host.id while the docker detector currently can only provide host.name.

This particular issue with the docker detector can potentially be mitigated by:

  1. Updating the docker detector to provide host.id. To be investigated.
  2. If 1 isn't possible, the entity type can potentially be called differently.

Even if we have a solution for this particular case, it's possible to run into other cases like this with other entity types. We can keep tracking them in this issue.

Based on the observations, we need to decide if we strictly define a set of identifying attributes for a particular entity type or keep it open while providing a list of recommended attributes.

@dmitryax dmitryax added this to Entities Oct 9, 2024
@dmitryax dmitryax converted this from a draft issue Oct 10, 2024
@dmitryax dmitryax changed the title Do we allow different identifying attributes? [entities] Do we allow different identifying attributes? Oct 10, 2024
@svrnm svrnm added sig-issue A specific SIG should look into this before discussing at the spec entities labels Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
entities sig-issue A specific SIG should look into this before discussing at the spec
Projects
Status: Todo
Development

No branches or pull requests

2 participants