-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagators section clean up #453
Comments
add: having only Get in the Getter is incompatible with OpenTracing, e.g. Jaeger's baggage cannot be retrieved via Get because the headers include the user's baggage key, e.g. |
We don't need to, but it allows using a singleton object for getter/setter and an already existing object for carrier instead of creating a new combined object just for telemetry. However, I think the carrier should be an optional (i.e. nullable) argument. |
Talking with @carlosalberto today, looks like only thing left from the description of this issue is:
So bumping this down to P3. |
In #440 a few issues arose about the overall structure and current content of
api-propagators.md
:Carrier
interface, and mention it is mutable.Format
as a representation of the restrictions that a given message transport imposes on the data, and avoid the termformatter
.Fields
section needs to be clearer and not part of theHttpFormat
Carrier
andSetter
(and maybeGetter
)?The text was updated successfully, but these errors were encountered: