Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize on exclusion functionality for HTTP instrumentations #623

Open
toumorokoshi opened this issue May 27, 2020 · 3 comments
Open
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory

Comments

@toumorokoshi
Copy link
Member

toumorokoshi commented May 27, 2020

There's a few PRs on the Python side to introduce denylists of specific HTTP paths and hosts:

open-telemetry/opentelemetry-python#670

Is this an area that we should consider incorporating into conventions? I feel like it would be great to work on a standard that works for a variety of scenarios around http span denylist, and to ensure similar functionality is provided across languages.

@arminru
Copy link
Member

arminru commented May 27, 2020

There was some discussion regarding that a year ago on #173 but no concrete proposal.

@toumorokoshi
Copy link
Member Author

@arminru got it. Thanks for the information.

I'll at least start gathering some information, and maybe others came chime into the discussion.

From the python perspective, our excludes currently support two matches:

  • exclude by host, which looks at the hostname and will exclude based on substring match
  • exclude by path, which looks at the fully qualified path prefix and excludes based on that.

Example: https://github.com/open-telemetry/opentelemetry-python/tree/master/ext/opentelemetry-ext-django

Currently they are namespaced by instrumentation, although I believe values could most likely be shared:

  • OPENTELEMETRY_PYTHON_{NAME}_EXCLUDED_HOSTS
  • OPENTELEMETRY_PYTHON_{NAME}_EXCLUDED_PATHS

@bogdandrutu
Copy link
Member

@toumorokoshi please make sure you DON'T use blacklists use alternatives like exclude or other options.

@bogdandrutu bogdandrutu added area:semantic-conventions Related to semantic conventions spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory labels Jun 26, 2020
@reyang reyang added the release:after-ga Not required before GA release, and not going to work on before GA label Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions release:after-ga Not required before GA release, and not going to work on before GA spec:metrics Related to the specification/metrics directory spec:trace Related to the specification/trace directory
Projects
None yet
Development

No branches or pull requests

4 participants