-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify values for OTEL_LOG_LEVEL #920
Comments
From the SIG spec meeting: We are not sure if we can properly align the log level across all frameworks that may be plugged into each SDK and should reconsider if Apart from that, the name |
Even with adding a "debug" flag, for Java, I would expect to just set my logging implementation to log |
Not necessarily. We can check for the presence of |
@iNikem but...we don't know "my logging implementation" in the SDK, do we? This implementation could be log4j, slf4j-simple, logback, etc. |
We are talking about SDK logging, write? We can configure |
How does that work if the underlying logging is all being redirected to another logging implementation? I'm actually not sure how that ends up working, TBH. |
Implementing a |
This does need to be clarified and a while back @tedsuo bought up that we should define the API/SDK Diagnostic logging discussion to happen after the convenience API and I was going to help drive this. From a JS API perspective we have already defined and using a Diagnostic API and we have defined the following levels which are used for the SDK OTEL_LOG_LEVEL, note that we only support this environment variable being defined as a "String" so that we are free to fiddle with the actual enumeration values within the API/SDK From my perspective we should NOT link this with the Logging specification as these are different concepts, but the renaming to something more specific would be nice to avoid overloading perhaps |
The spec defines an
OTEL_LOG_LEVEL
environment variable for general SDK configuration, but it is unclear what values should be allowed. Since this variable does not have a language prefix, there should probably be a unified set of log levels specified.We could link to the Log Data Model, which already specifies log levels.
The text was updated successfully, but these errors were encountered: