Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

B3 underspecified #960

Closed
mwear opened this issue Sep 16, 2020 · 0 comments · Fixed by #961
Closed

B3 underspecified #960

mwear opened this issue Sep 16, 2020 · 0 comments · Fixed by #961
Assignees
@mwear
Labels
priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:context Related to the specification/context directory spec:trace Related to the specification/trace directory

Comments

@mwear
Copy link
Member

mwear commented Sep 16, 2020 •
edited
Loading

What are you trying to achieve?

Consistency in B3 context propagation between different SDK implementations.

Additional context.

B3 has single and multi-header formats. Most languages have support for both formats, but not all. To ensure consistency between SDK implementations we should specify what is expected. Based on surveying the go, python, and java implementations, we should specify that B3 propagators:

  • MUST support extracting context from both single and multi-header encodings
  • MUST default to injecting context using the multi-header encoding, but
    MAY provide configuration to change the default

The spec currently says that B3 and Jaeger MUST be distributed as extension packages. Only the java implementation is doing this. Can these propagators be distributed with the SDK if a language chooses?

I preemptively prepared a pull-request with the changes proposed in this issue: #961.
@mwear mwear added the spec:context Related to the specification/context directory label Sep 16, 2020
This was referenced Sep 16, 2020
Merged
Closed
@andrewhsu andrewhsu added priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory labels Sep 18, 2020
@carlosalberto carlosalberto mentioned this issue Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwear mwear

Labels
priority:p1 Highest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:context Related to the specification/context directory spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

B3 clarification mwear/opentelemetry-specification
2 participants
@andrewhsu @mwear