Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo docs: Architecture picture fit #2281

Closed
Tracked by #2289
mviitane opened this issue Feb 7, 2023 · 4 comments · Fixed by #2318 or #2320
Closed
Tracked by #2289

Demo docs: Architecture picture fit #2281

mviitane opened this issue Feb 7, 2023 · 4 comments · Fixed by #2318 or #2320

Comments

@mviitane
Copy link
Member

mviitane commented Feb 7, 2023

The demo architecture picture has quite large spaces around it. The picture would work better with removed extra spaces from the top, bottom, and side (if possible).

Using a preview of #2275
https://deploy-preview-2275--opentelemetry.netlify.app/docs/demo/current_architecture/

image


Edit(@chalin): link to old repo docs showing the diagram, https://github.com/open-telemetry/opentelemetry-demo/blob/4b8bb4554b8888c712349d26679cca109f4c575e/docs/current_architecture.md

@svrnm
Copy link
Member

svrnm commented Feb 7, 2023

looks like an issue with mermaid, the space comes from the rendered SVG?

@mviitane
Copy link
Member Author

mviitane commented Feb 7, 2023

One more item to the wish list for the architecture picture: Zoom-in.
The main arch picture contains so much details that a feature to enlarge the picture with one click would be very useful when presenting / screen sharing.

@chalin
Copy link
Contributor

chalin commented Feb 7, 2023

Thanks for the continue feedback @mviitane. Yeah, I had seen the issue with the Mermaid-generated image, but didn't find a way to address it on first investigation. I'd dig deeper.

@chalin
Copy link
Contributor

chalin commented Feb 10, 2023

Sigh, #2318 doesn't fix it for Safari and Firefox so I'm reopening this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants