Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Ensure section-local image paths fall back to default lang image #4761

Closed
Tracked by #4467
chalin opened this issue Jun 27, 2024 · 1 comment · Fixed by #4790
Closed
Tracked by #4467

[i18n] Ensure section-local image paths fall back to default lang image #4761

chalin opened this issue Jun 27, 2024 · 1 comment · Fixed by #4790
Assignees
Labels
CI/infra CI & infrastructure i18n internationalization

Comments

@chalin
Copy link
Contributor

chalin commented Jun 27, 2024

Originally posted by @chalin in #4741 (comment)

Hugo is now setup to reuse the default language image -- the exact same file, no duplication (as was the case for static resources a few Hugo versions ago).

Images should not be duplicated. I'd suggest using the default image except where there's too much English text in the image, of course.

@chalin chalin self-assigned this Jun 27, 2024
@chalin chalin added i18n internationalization CI/infra CI & infrastructure labels Jun 27, 2024
@chalin chalin mentioned this issue Jun 27, 2024
41 tasks
@chalin
Copy link
Contributor Author

chalin commented Jul 2, 2024

Actually, it just works (as I expected originally, but was confused by the ja PR that included an image override). Will keep this open for a little while longer; maybe until I at least add a comment to the i18n docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure i18n internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant