Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[i18n] Ensure that fall-back redirect pages like API and Examples under Language work for non-en localizations #4898

Closed
chalin opened this issue Jul 27, 2024 · 4 comments · Fixed by #4906
Assignees
Labels
i18n internationalization

Comments

@chalin
Copy link
Contributor

chalin commented Jul 27, 2024

This is issue (1) from:

@zhihali
Copy link
Contributor

zhihali commented Jul 27, 2024

Hey, I'd love to give this a shot. I'm keen to get more familiar with the docs setup, so fixing these links would be a great way to dive in. Happy to take a crack at it if you're cool with that!

understand this should be implement after #4895, as you said.

@chalin
Copy link
Contributor Author

chalin commented Jul 27, 2024

Thanks for the offer, but I'd rather work on this given that I'm still designing the i18n support for OTel. Unless you are very, very familiar with Hugo and the design of this site, I'd suggest you work on addressing #4893.

@chalin
Copy link
Contributor Author

chalin commented Jul 28, 2024

@zhihali - To give you an idea, here's an example of the kind of refactoring I wanted & needed to do before fixing this issue:

@zhihali
Copy link
Contributor

zhihali commented Jul 28, 2024

no problem, @chalin, will leave this to you! Will keep an eye on your PR and learn from it🙂

Thanks for the offer, but I'd rather work on this given that I'm still designing the i18n support for OTel. Unless you are very, very familiar with Hugo and the design of this site, I'd suggest you work on addressing #4893.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n internationalization
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants