-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate the authentication configuration for collector #673
Comments
If it was removed, that's because it was removed in the canonical copy on the collector documentation, so it needs to be re-added there. |
Is this something new? Would you mind pointing me to the right place to add? |
Been this way since May - open-telemetry/opentelemetry-collector#2839 You update the docs in the collector repo then run an action to merge them over here. I'll be talking about some changes to this process we're going to introduce during today's maintainer meeting as well. |
Alright, I'll get it there. For reference, this is the PR that added the auth doc: #605 |
@jpkrohling - thanks for alerting us to the fact that #605 was mistakenly undone/overwritten by #649. As I mention in open-telemetry/opentelemetry-collector#4041 (comment), we're in the process of migrating the collector docs back into the website repo (#731) so as to avoid such problems in the future. Would you mind closing open-telemetry/opentelemetry-collector#4041? Also let me know whether you'd like to resubmit the equivalent of #605 yourself or whether you'd like me to do so. |
If it's easy for you to reinstate it, go for it! Otherwise, I can do it as well. |
@jpkrohling - PR #734 adds the pages back. |
The PR #649 removed the authentication configuration for the collector. Please, reinstate that.
cc @flands, @austinlparker
The text was updated successfully, but these errors were encountered: