Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish the specification via opentelemetry.io #852

Closed
2 tasks done
Tracked by #833 ...
chalin opened this issue Oct 21, 2021 · 22 comments
Closed
2 tasks done
Tracked by #833 ...

Publish the specification via opentelemetry.io #852

chalin opened this issue Oct 21, 2021 · 22 comments
Labels
analytics-and-seo CI/infra CI & infrastructure e1-hours Effort: < 8 hrs enhancement New feature or request IA Information architecture rework

Comments

@chalin
Copy link
Contributor

chalin commented Oct 21, 2021

The spec is a core OTel resource, and as such it should be published through this repo. (#833)

@chalin chalin added enhancement New feature or request CI/infra CI & infrastructure e1-hours Effort: < 8 hrs analytics-and-seo labels Oct 21, 2021
@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2021

Thoughts? @tedsuo @bhs @open-telemetry/specs-approvers

@bhs
Copy link
Contributor

bhs commented Oct 21, 2021

@chalin Per your note elsewhere, I will raise this with the GC today.

@bhs
Copy link
Contributor

bhs commented Oct 21, 2021

@chalin I'm live-blogging the GC meeting that's happening right now :)

You're welcome to check the recording, but the consensus is that, while we want the website to be the first port of call for end-users, we want to have a single source of truth for the spec and that must be GitHub. We will continue to push end-user getting-started docs/etc into OTel.io, though, as that will be better for the adopter community.

@austinlparker
Copy link
Member

@bhs we could pull the specification in via submodule if we wanted to have a single source of truth.

@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2021

@bhs we could pull the specification in via submodule if we wanted to have a single source of truth.

Right!

We're one step ahead already: the spec is already a submodule of this repo: see in https://github.com/open-telemetry/opentelemetry.io/tree/main/content-modules.

@austinlparker
Copy link
Member

As a first step, we should add a 'Specification' category to the left nav in /docs that links to the main GitHub repo for specs.

@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2021

@bhs - other than the obvious SEO benefit, hosting the spec on the website gives us the ability to do redirects: as the spec evolves over time, and pages or sections get moved or renamed, the website redirects can ensure that readers don't get 404s. This isn't something you get when linking directly to GH pages.

@reyang
Copy link
Member

reyang commented Oct 21, 2021

Couple things need to be clarified:

  1. Do we only publish Stable version of specs, or we also publish Experimental specs? What to do if a spec status is Mixed?
  2. Do we only publish the latest-stable version, or we publish ALL the stable versions?

@chalin chalin mentioned this issue Oct 21, 2021
32 tasks
@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2021

Good questions.

I'd suggest starting with the latest-stable version (no experimental).

@lizthegrey
Copy link
Member

I'm good with posting a copy of the spec to the website as long as it gets updated automatically, and requests to edit go to the main spec docs rather than editing a fork.

@chalin
Copy link
Contributor Author

chalin commented Oct 29, 2021

Thanks for the feedback @lizthegrey!

I'm good with posting a copy of the spec to the website as long as it gets updated automatically, ...

If that's what y'all prefer, it can be setup.

and requests to edit go to the main spec docs rather than editing a fork.

That's already working. For example, try the Edit page link of the following page: https://deploy-preview-866--opentelemetry.netlify.app/docs/specification/overview/

@tedsuo
Copy link
Contributor

tedsuo commented Oct 29, 2021

My only note (besides agreeing that it should be the latest stable version, which is released once a month) is that unless the change is a minor clarification, updating the spec is done through OTEPs.

I'm not sure adding an "update this page" conveys the gravity of making a spec change. That makes it look too much like a doc change on the website. I don't believe we should provide that feature for the spec, we are not encouraging spec PRs without issues being opened first or OTEPs being created.

@yurishkuro
Copy link
Member

I agree with @tedsuo. It's fine to have a link to the source page in the spec, without making it an Edit link.

@austinlparker
Copy link
Member

I chatted with bhs as well; The concern was specifically about synchronization issues. I'm going to summarize what I think the key blockers are here:

  • Edit link in right sidebar should be removed.
  • Automation to create new PR when tagged spec release occurs is implemented.

@tedsuo
Copy link
Contributor

tedsuo commented Oct 29, 2021

Looking at the layout, I also suggest that the spec should not be listed so prominently in our documentation. The spec is not intended to be end user documentation; I'm concerned that it will be distracting and confusing to list it at the top of the navigation, as that implies that it is a primary resource for end users which they need to read.

Users should never have to read the spec to make use of OTel.

@austinlparker
Copy link
Member

Perhaps it should be under 'concepts'?

@chalin
Copy link
Contributor Author

chalin commented Oct 29, 2021

Looking at the layout, I also suggest that the spec should not be listed so prominently in our documentation

Ok. Under the new IA (once it is defined via #770), I would imagine that it would make sense to have a Reference section, with the spec under that.

Until we have a new IA I can I can think of a these options:

  1. Not show the Specification section in the sidenav.
  2. Show the Specification in the sidenav but move it towards the end of the list.
  3. Add a Referrence section now (even before we have the new IA) and place the spec there from the start.

Thoughts?

@austinlparker
Copy link
Member

austinlparker commented Oct 29, 2021

I like option 3.

@tedsuo
Copy link
Contributor

tedsuo commented Oct 29, 2021

Option 3 sounds good

@chalin
Copy link
Contributor Author

chalin commented Nov 4, 2021

@tedsuo @austinlparker et al - Done:

  • I've implemented option 3, and
  • Replaced the "Edit page" button by a "View page source"

PTAL https://deploy-preview-866--opentelemetry.netlify.app/docs/reference/specification/

@austinlparker
Copy link
Member

austinlparker commented Nov 4, 2021

Since we've addressed the issues raised here outside of automation (which would take a bit to solve in a generalized fashion), we'll commit to a one business day turnaround for updates when new spec releases are cut from notification.

With that in mind, unless there are other blockers we'll be merging #866 next Tuesday.

@chalin
Copy link
Contributor Author

chalin commented Nov 9, 2021

Closed by #866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analytics-and-seo CI/infra CI & infrastructure e1-hours Effort: < 8 hrs enhancement New feature or request IA Information architecture rework
Projects
None yet
Development

No branches or pull requests

7 participants