Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Establish consistent guidelines for organizing vendor specific contributions to the OpenTelemetry Collector #141

Open
alolita opened this issue Nov 3, 2020 · 1 comment
Labels
release:allowed-for-ga Editorial changes that can still be added to the GA spec since they don't require action by SIGs

Comments

@alolita
Copy link
Member

alolita commented Nov 3, 2020

Today, some vendor contributed components are being accepted into the OpenTelemetry Collector repositories. Other vendor contributions are being rejected. There are no consistent rules for merging vendor specific code in the OpenTelemetry Collector repositories.

I propose that all vendor specific components for the Collector reside in the “github.com/open-telemetry/opentelemetry-collector-contrib” repository. This will facilitate static linking of all Go components needed by the user.
The alternative is that vendor components reside in vendor-hosted repositories which will lead to fragmentation of the Collector.

In particular, I request that the AWS authentication contribution supporting AWS SIGv4 for Collector based exporters reside in the github.com/open-telemetry/opentelemetry-collector-contrib repository. This would provide users with an easy-to-access, single source for all OpenTelemetry Collector components. In addition, it enables users to easily build exporters with statically linked SIGv4 support.

AWS will continue to maintain its component and create PRs against the collector-contrib repo for all revisions. We will work toward achieving collector-contrib maintainer status and then be able to manage code reviews and handle merging PRs appropriately. In the meantime, we will continue to submit PRs to be reviewed and merged into the collector-contrib repo by the current maintainers.

cc: Collector maintainers @bogdandrutu @tigrannajaryan

@andrewhsu andrewhsu added the release:allowed-for-ga Editorial changes that can still be added to the GA spec since they don't require action by SIGs label Nov 3, 2020
@tigrannajaryan
Copy link
Member

I propose that all vendor specific components for the Collector reside in the “github.com/open-telemetry/opentelemetry-collector-contrib” repository.

This is already our policy today. However, rejections of vendor-specific proposals are still possible on the technical merit of the contributions (low quality code, poor test coverage, etc) or because the contributions are not aligned with Collector vision and roadmap.

I think it will be useful to have a document that makes this abundantly clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:allowed-for-ga Editorial changes that can still be added to the GA spec since they don't require action by SIGs
Projects
None yet
Development

No branches or pull requests

3 participants