Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messaging.client.id duplicated when generating semconv 1.26.0 #1058

Closed
brettmc opened this issue May 22, 2024 · 1 comment
Closed

messaging.client.id duplicated when generating semconv 1.26.0 #1058

brettmc opened this issue May 22, 2024 · 1 comment
Assignees
Labels

Comments

@brettmc
Copy link

brettmc commented May 22, 2024

Area(s)

area:messaging

What happened?

Description

When generating semantic conventions with otel/semconvgen:0.24.0 I notice that messaging.client.id is duplicated: one "deprecated" and one "normal"

Steps to Reproduce (if any)

Expected Result

Only one entry for messaging.client.id

Actual Result

Semantic convention version

1.26.0

Additional context

I think what's going on is that whichever code generates a const name from a semconv attribute, is ending up with the same answer for messaging.client.id and messaging.client_id (note the _ vs .). We use {{ attribute.fqn | to_const_name }}

@brettmc
Copy link
Author

brettmc commented May 22, 2024

Closing, duplicate of #1031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants