-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change peer.service to service.origin.name and service.target.name? #1123
Comments
service.peer is AFAIK only explicitly configured. By extending this to service.origin/target, you'd need to make the configuration more complex (and e.g. if you call an auth service, is it then the target (of your call) or the origin (of the data)?) Why introduce another concept "origin" vs "target" when we already have "source" and "destination" in ECS (and had "host" and "peer" in OTel) |
maybe |
I think that would already be an improvement, but OTOH then it is neither ECS-aligned, nor compatible with old conventions, and I also still don't see the value in the distinction for this attribute? |
I think the value is similar to the value for |
We could add an attribute like otel.span_kind on any telemetry item supporting attributes (name inspired by https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/common/mapping-to-non-otlp.md). |
having
|
ECS
service.*
fields can be self-nested underservice.origin.*
andservice.target.*
, which has a similar purpose as thepeer.service
in OTel. Similar to our previous discussions onclient / server
andsource / destination
, hereservice.origin.*
andservice.target.*
make the relationship more explicit, without the need to know the context of the field._Originally posted by @AlexanderWert in #1012
The text was updated successfully, but these errors were encountered: