You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
name: `GET users/{id}` <- the same as on span 1 and not a template of `url.full` on this span
url.template: https://host:port/users/{id} <- the same as on span 1 and not a template of `url.full` on this span
url.full: https://anotherhost/something/else/42?foo=bar
http.response.status_code = 200
In case of Java example with Spring WebClient above, it's clear that template applies only to the first request.
In the case of the second example (ambient context) it's not clear at all.
We can probably tolerate it (possible mismatch in template/url for redirects), but we should provide some clarity in the spec (e.g. something along the "the template SHOULD be related to the url on the same span" lines).
The text was updated successfully, but these errors were encountered:
agreed.
Still, the ability to follow this would depend on the mechanism used to provide url.template.
It won't be possible with context-scoped attributes:
// imaginary
using (Context.AddAttribute("url.template", "/users/{id}")) {
await httpClient.SendAsync(request);
}
Even without redirects, everything that's a pure user input is should and not SHOULD.
Extracted from #1095
In case user provides a template similarly to
or
but then a redirect happens, then it's not clear whether
url.template
should apply to all HTTP spans created within this scope.E.g. we can end up with:
Span 1:
Span 2:
In case of Java example with Spring WebClient above, it's clear that template applies only to the first request.
In the case of the second example (ambient context) it's not clear at all.
We can probably tolerate it (possible mismatch in template/url for redirects), but we should provide some clarity in the spec (e.g. something along the "the template SHOULD be related to the url on the same span" lines).
The text was updated successfully, but these errors were encountered: