-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should messaging.kafka.message.offset
be in the message namespace?
#1156
Comments
I'm in favor of making this a generic attribute (outside the I have no strong opinion whether it should be |
Related: #1036 |
Did some research on the terminology used by different messaging systems:
|
Based on this, I would prefer |
Discussed in the workgroup meeting, we will go with the proposal from @lmolkova in the previous comment. |
Kafka settlement is offset-based.
When reporting settlement, we'd want to include
messaging.kafka.message.offset
on the settlement span as shown in #1155. But that span does not have to be reported per message (it can be done in the background periodically, for each 1000th message, etc).It looks weird to have the offset attribute in the message namespace as it's not just a message property, but also a thing on its own. Someone may also want to create a metric for the offset (e.g. latest published offset vs latest consumed offset would show the size of the queue). In this case it's rather a property of the topic/consumer group.
Suggesting
messaging.kafka.offset
or even a more generic onemessaging.offset
since offset concept is popular in messaging world.The text was updated successfully, but these errors were encountered: