-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database/Messaging extensions: revise extends in yaml #360
Comments
Merged
3 tasks
/cc @estolfo |
3 tasks
lmolkova
changed the title
Elasticsearch semconv: should it extend DB semconv?
Database extensions: revise extends in yaml
Oct 19, 2023
lmolkova
changed the title
Database extensions: revise extends in yaml
Database/Messaging extensions: revise extends in yaml
Mar 18, 2024
github-project-automation
bot
moved this to V1 - Stable Semantics
in Spec: Messaging Semantics
Mar 18, 2024
I believe we should provide all the applicable attributes in the system-specific md tables for all databases and messaging extensions. It would provide clarify to the readers and instrumentation authors and allow semconv authors to document system-specific things about the attributes. |
yes, #869 is wider than this one. Let's close this one. |
github-project-automation
bot
moved this from Todo
to Done
in Database Client Semantic Conventions
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Came up in #359 (comment).
UPDATE: based on the discussion in Semconv WG:
extend
base db conventions in yaml.The context:
Elasticsearch semconv extends
db
in yaml, but re-referenced attributes in theserver.*
namespace, so it's unclear what was the original intent and what the actually full semconv should be:Option 1:
If Elastic should only report attributes currently defined/referenced in yaml (without extending db), then all the attributes are
<!-- semconv db.elasticsearch -->
db.elasticsearch.cluster.name
db.elasticsearch.node.name
db.elasticsearch.path_parts.<key>
db.operation
db.statement
http.request.method
server.address
server.port
url.full
Option 2:
If elasticsearch should extend DB, then it implicitly includes the following attributes (if a full MD table is rendered)
<!-- semconv db.elasticsearch(full) -->
db.connection_string
db.elasticsearch.cluster.name
db.elasticsearch.node.name
db.elasticsearch.path_parts.<key>
db.jdbc.driver_classname
db.name
db.operation
db.statement
db.system
db.user
network.transport
network.type
server.address
server.port
server.socket.address
server.socket.domain
server.socket.port
url.full
The text was updated successfully, but these errors were encountered: