Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review sampling relevant flag for attributes that are part of upcoming HTTP semconv stability #463

Closed
trask opened this issue Oct 27, 2023 · 1 comment · Fixed by #467
Closed
Assignees

Comments

@trask
Copy link
Member

trask commented Oct 27, 2023

(related Azure/azure-sdk-for-java#26988 (comment))

@trask
Copy link
Member Author

trask commented Oct 29, 2023

Existing sampling_relevant attributes:

HTTP client spans

  • http.request.method
  • server.address
  • server.port
  • url.full

HTTP server spans

  • http.request.method
  • server.address
  • server.port
  • url.path
  • url.query
  • url.scheme

Potential additional sampling_relevant attributes:

HTTP server spans

  • user_agent.original - I think ok to assume headers are available on span start (we already do this for server.address which is based on host header)
  • http.request.header.<key> - same
  • client.address - seems useful for sampling from a specific client or address block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2 participants