-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging.operation.type attribute should not be required #947
Comments
Options:
|
My preference is on the Option 1 side - I want to reevaluate why we need operation type, especially if we're considering having Also, with |
I would favor a solution where Currently it's the only required attribute besides I suggest: |
Can we revisit this and clarify why is it important? How exactly is it going to be used? |
It gives you a well-defined list of values which can be interpreted independently of the messaging system used. Regarding use-cases, for example it lets you ask questions like "give me spans for all settlement operations that caused an error" in a non-system specific way.
For
I'd be curious how others think about this, but for me that's a bit overwhelming without a categorization mechanism like the operation type provides it. If folks think |
Thanks, it makes total sense. So it's less of a span visualization problem and more a metrics (or custom queries) concern. The concerns I still have:
What I'm saying that the value operation.type provides does not seem to be essential, but most importantly, it can be added later at any point without breaking anything. And I'm proposing to remove it altogether and make operation name required. |
That's fair, let's discuss it in the next workgroup meeting. |
I read everything and to me also makes sense that operation name is required. I like the idea of a high-level classification but I'm not sure if it really makes sense which probably is a good indication to leave it out for now. |
The PR for For messaging, this could result in values like e. g. |
Based on the SIG discussion, we're tentatively aligned on removing |
Operation type identifies common messaging operations (which may be called differently in specific systems): e.g.
publish
can be calledsend
,schedule
, orenqueue
.In such cases we use
messaging.operation.name
to represent system-friendly name.However there are other types of operations that don't match any common type. E.g,
cancel scheduled message
,delete
,create topic
, etc...While those are not targeted for stability, we should make sure
messaging.operation.type
requirement level is adequate and future-proof.Originally posted by @lmolkova in #942 (comment)
The text was updated successfully, but these errors were encountered: