Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests to validate the semconv registry resolution process #8

Closed
Tracked by #13
lquerel opened this issue Feb 10, 2024 · 0 comments · Fixed by #123
Closed
Tracked by #13

Add more tests to validate the semconv registry resolution process #8

lquerel opened this issue Feb 10, 2024 · 0 comments · Fixed by #123
Labels
enhancement New feature or request

Comments

@lquerel
Copy link
Contributor

lquerel commented Feb 10, 2024

Right now it's not obvious that the existing tests cover all the various configurations observed in the existing official semconv registry.

The current tests are located in the weaver_resolver crate and more specifically in the registry module.
The new data model used to represent the resolved registry is present in the weaver_resolved_schema crate.

Note: there is a previous attempt, in the code base, for this resolution process trying to resolve both the semconv registry and the telemetry schema. This part of the code will be removed soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant