Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need didRender focus handling for bulma-modal-close? #47

Open
alexdiliberto opened this issue Dec 6, 2016 · 1 comment
Open

Comments

@alexdiliberto
Copy link
Contributor

This is here as a placeholder issue.

Lets determine if we want to have any type of focus handling for the close button on modal render. I removed this due to inconsistencies, as it's currently not working with Ember 2.6.1 but is working with Ember 2.10.0

  //TODO Not working
  /**
    *
    */
  didRender() {
    this.$().focus();
  }
@jbailey4
Copy link
Member

@alexdiliberto What I've experienced by other addons is that focus handling, and a11y in general, is left to the consumer to implement.

I'm not against supporting this though. Perhaps we do this by default, and provide a way for consumers to opt-out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants