Fix Extensions

[manuth]

• I have read the note above about PRs contributing or fixing extensions
• I have tried reaching out to the extension maintainers about publishing this extension to OpenVSX (if not, please create an issue in the extension's repo using this template).
• This extension has an OSI-approved OSS license (we don't accept proprietary extensions in this repository)

Description

As seen in the Publish extensions to open-vsx.org workflow, there is quite a number of extensions which is not able to build at the moment.
The goal of this PR is to fix all extensions which aren't able to build at time of writing.
All one-time fixes are guarded with version-comparisons (using the new environment variables described in the Environment paragraph).

Fixing all non-functioning extensions will help to detect, address and fix future issues with extensions more efficiently.
Everything that has been changed is documented below.

Environment

In order to make applying workarounds and advanced actions in custom- and prepublish-commands easier, a few environment variables were added:

• EXTENSION_ID which contains the id of the extension being published (e.g. rebornix.ruby)
• EXTENSION_PUBLISHER the name of the publisher (e.g. rebornix)
• EXTENSION_NAME the name of the extension (e.g. ruby)
• VERSION the version the extension is assumed to have
• MS_VERSION the latest version of the extension on microsoft's marketplace
• OVSX_VERSION the latest version of the extension on Open VSX

Furthermore, a chapter about said environment variables was added to the README.

Updated Extensions

Added

• ms-dotnettools.vscode-dotnet-runtime (required by some extensions which currently fail to build)

Fixed

Following extensions were fixed:

• appulate.filewatcher (PR Fix Incorrect Variable Type appulate/vscode-file-watcher#16, see Abandoned-Looking Extensions below)
• adamhartford.vscode-base64 (PR for requesting fixing changes Fix installation errors adamhartford/vscode-base64#8 created by @filiptronicek, see Abandoned-Looking Extensions below)
• arjun.swagger-viewer (PR Fix Broken Build Process arjun-g/vs-swagger-viewer#110, see Abandoned-Looking Extensions below)
• bierner.markdown-image-size (PR Fix build process mjbvz/vscode-markdown-image-size#5)
• bmalehorn.vscode-fish (PR Fix Build Process bmalehorn/vscode-fish#26)
• formulahendry.vscode-node-red (PR Fix Build Process formulahendry/vscode-node-red#26, see Abandoned-Looking Extensions below)
• fraser.live-coder (Creating PRs in GitLab doesn't seem to be possible, see Abandoned-Looking Extensions below)
• halcyontechltd.git-client-ibmi (PR Fix typo codefori/git-client-ibmi#6)
• hashicorp.terraform
• ikappas.composer (PR Fix Build Process ikappas/vscode-composer#22)
• ikappas.phpcs (PR Fix Build Process ikappas/vscode-phpcs#198)
• iocave.monkey-patch (by removing the src/test-directory)
• jock.svg (PR Fix Build Process lishu/vscode-svg2#107)
• johnsoncodehk.volar
• johnsoncodehk.vscode-typescript-vue-plugin
• justusadam.language-haskell
• marus25.cortex-debug (by installing the exact package-lock.json dependencies using npm ci)
• miguel-savignano.ruby-symbols (PR Fix Build Process MiguelSavignano/vscode-ruby-symbols#13)
• ms-vscode.js-debug-companion (by git checkouting the (at time of writing) most recent commit)
• ms-vscode.mock-debug
• ms-vscode.vscode-js-profile-flame
• ms-vscode.vscode-js-profile-table
• neikeq.godot-csharp-vscode by performing the building in a nested docker container (PR Fix Webpack Config for Newer NodeJS Versions godotengine/godot-csharp-vscode#41)
• oouo-diogo-perdigao.docthis (PR Fix Build Process oouo-diogo-perdigao/vscode-docthis#10)
• paiqo.databricks-vscode (PR Fix Build Process paiqo/Databricks-VSCode#72)
• peterj.proto (PR Fix Build Process peterj/vscode-protobuf#2)
• reduckted.vscode-gitweblinks
• rebornix.ruby (PR Fix Build Process rubyide/vscode-ruby#810)
• rintoj.json-organizer (PR Fix Build Process rintoj/json-organizer#2)
• saltud.type4py (PR Fix Build Process saltudelft/type4py-vscode-ext#25)
• serayuzgur.crates
• sodatea.velocity (PR Fix Build Process haoqunjiang/vscode-velocity#10)
• shuworks.vscode-table-formatter (PR Fix Build Process shuGH/vscode-table-formatter#31)
• styled-components.vscode-styled-components
• vscode-org-mode.org-mode (PR Fix Build Process vscode-org-mode/vscode-org-mode#204)
• vshaxe.hxcpp-debugger
• wmaurer.change-case (PR Fix Build Process wmaurer/vscode-change-case#43)
• Wscats.eno (PR Fix Build Process Wscats/compile-hero#151)
• xdebug.php-debug
• xirider.livecode (PR Fix Build Process Xirider/LiveCode#9)

Renamed

Furthermore, some extensions were renamed:

• andreweinand.mock-debug replaced w/ ms-vscode.mock-debug
• felixfbecker.php-debug replaced w/ xdebug.php-debug
• jpoissonnier.vscode-styled-components replaced w/ styled-components.vscode-styled-components

Non-Functioning Extensions

Some extensions don't work yet
Following extensions do not have an open source license assigned:

• ChakrounAnas.turbo-console-log (Issue Add an Open Source License to the Project Chakroun-Anas/turbo-console-log#160)
• Dannark.AndroidLauncher (Issue Add an Open Source License to the Project Dannark/Android-Launcher-for-VSCode#13)
• joelday.docthis (Extension doesn't seem to exist anymore)
• ms-python.devicesimulatorexpress (Extension has been de-listed)
• ms-vscode.vscode-js-profile-notebook doesn't exist yet

Abandoned-Looking Extensions

Some of the extensions which won't work until this PR is merged, might be abandoned.
This list contains extensions with both at least 1 Pull Request which were without any activity for at least 1 month and a repository with at least 1y of inactivity.

• appulate.filewatcher
• adamhartford.vscode-base64 (repo inactive for about 4y)
• arjun.swagger-viewer (probably inactive? repo inactive for about 9 months)
• formulahendry.vscode-node-red (most likely abandoned - inactive for about 4y. Requires tampering the code)
• fraser.live-coder (2y of inactivity)
• ikappas.composer (probably inactive? repo inactive for 8 months)
• wmaurer.change-case (repo inactive for 6 years)

[filiptronicek]

@manuth thanks for taking a look at so many extensions. I see you are fixing up some things based on the version of the extensions published. Are those unmaintained extensions that would not be fixable by PRs in their respective repos?

If so, let's make PRs to encourage extension authors to make their extensions build, and if the extensions are unmaintained, I would rather publish them just once via https://github.com/open-vsx/publish-extensions/blob/master/.github/workflows/publish-once.yml.

If you agree with publishing some extensions once, could you make a list somewhere 🙏?

[manuth]

Thahks for having a look at this PR 😄
I added the version guard to make sure the workaround won't be applied on upcoming versions. That way, the custom property won't destroy (or tamper) upcoming versions.

I'll make sure to add a list with abandoned extensions and build commands to have them published once.

[manuth]

@filiptronicek is there something more to be done or to consider before we can get this PR merged?
I'm ready from my side 😄

[filiptronicek]

@manuth I am going to take another look now, I'd love to get this merged soon, just have some other things to finish up 👀.

[manuth]

@manuth I am going to take another look now, I'd love to get this merged soon, just have some other things to finish up 👀.

No worries I just wanted to make sure I'm not missing something 😄
Thank you so much for taking care ^^

[filiptronicek]

Reviewed the rest and made some changes. This PR LGTM! So glad you made the time for it, thanks again @manuth.

[filiptronicek]

I have to sadly remove the very-hard-to-package-up the neikeq.godot-csharp-vscode extension, because it depends on a proprietary extension from Microsoft, ms-dotnettools.csharp [1]. This makes the publishing fail [1] and sadly there is so far no good way to get around it AFAIK :/

cc @manuth

[manuth]

Before you do, I'll go try whether the Open Source alternative of the OmniSharp extension.

Maybe it works with it out of the box. I really hope it does 🥲😂

[filiptronicek]

Let's see @manuth, as I already commited the removal, should I revert it? I guess we can do this just as a PR and merge afterwards, keep the removal commit there until that.

[manuth]

@filiptronicek Thanks for taking care 😄
I managed it to get it to work by replacing the extension dependencies with muhammad-sammy.csharp.
Funny enough, I even got the "C# Tools for Godot" debugging to run without muhammad-sammy.csharp, so I'm not sure what it's in the dependencies for (perhaps for a better C# coding experiences).

Could you please revert the changes?
I'll open up a PR adding a workaround which replaces the extension dependencies with muhammad-sammy.csharp asap!

Thanks a ton 😄

[filiptronicek]

@manuth done :) d0889ed