Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frame-benchmarking support #998

Open
clangenb opened this issue May 3, 2024 · 1 comment
Open

frame-benchmarking support #998

clangenb opened this issue May 3, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@clangenb
Copy link
Contributor

clangenb commented May 3, 2024

I have noticed that the runtime didn't really like when the benchmarking macro from this repository is mixed with the benchmarking macro from substrate. Hence, I have re-implemented the orml-vesting benchmarks with substrate's macro, here.

It only contains the benchmarks for the orml-vesting pallet currently. Is this something that you'd be interested in having upstreamed?
@xlc
Copy link
Member

xlc commented May 3, 2024

yeah that will be great. the new benchmark syntax and omni bencher have solved a lot of issues that the old one had and now it is a good time to migrate to it

@xlc xlc added the good first issue Good for newcomers label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xlc @clangenb