Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENABLE_OLLAMA_API being set to false if ollama.enabled is false #86

Closed
thaynes43 opened this issue Sep 27, 2024 · 2 comments · Fixed by #88
Closed

ENABLE_OLLAMA_API being set to false if ollama.enabled is false #86

thaynes43 opened this issue Sep 27, 2024 · 2 comments · Fixed by #88
Labels
bug Something isn't working

Comments

@thaynes43
Copy link

I don't want Ollama automatically installed but I still want to set a base URL and have the API enabled.

A change went into the 3.1.x version of the chart that sets ENABLE_OLLAMA_API to false if ollama.enabled is false. The commit message seems to imply the opposite though, 2062a5d but it is not setting the URL if Ollama isn't set to be automatically deployed. See this comment https://github.com/open-webui/helm-charts/blob/main/charts/open-webui/values.yaml#L4 for how enabling ollama is to deploy it vs. just to use the API.

Rolling the chart back to 3.1.18 fixes this for me. I am unable to go up to 3.2.x because my ODIC log in stops working after the change to config maps but since this issue was introduced first (and looks to be copied into the ConfigMap change) I'll look more into that after this.

Thanks!

@0xThresh
Copy link
Collaborator

Thanks for the report @thaynes43, that's definitely an oversight. I'll have time to fix this over the weekend, PR welcome if you want to beat me to it though. Thank you!

@0xThresh 0xThresh added the bug Something isn't working label Sep 27, 2024
@davizucon
Copy link
Contributor

Hey @thaynes43, you are right, need to take into account that you still can use API the without deploying it.
Looks like #88, fix both OIDC and OLLAMA URL. I'm following this one.

p.s.: @0xThresh, feel free to tag me, I'll take a look right away.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants