You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm using pairtools.lib.scaling.compute_scaling from the latest master branch (SHA: 1e8d518) to create interaction decay curves from pairs files.
When I use the default value of the keyword argument dist_range, the function runs without errors but if I choose a distance range that is narrower e.g. dist_range=(int(1e1), int(1e6)), I get the following error:
The error seems easy enough to fix: append np.inf to the end of dist_bins array provided to bins_pairs_by_distance and change this line in scaling.py from pairs_reduced_df["dist_bin_idx"] < len(dist_bins), to pairs_reduced_df["dist_bin_idx"] < len(dist_bins) - 1,
Thoughts? I'm happy to create a pull request with these changes.
The text was updated successfully, but these errors were encountered:
I'm using
pairtools.lib.scaling.compute_scaling
from the latest master branch (SHA: 1e8d518) to create interaction decay curves from pairs files.When I use the default value of the keyword argument
dist_range
, the function runs without errors but if I choose a distance range that is narrower e.g.dist_range=(int(1e1), int(1e6))
, I get the following error:The error seems easy enough to fix: append
np.inf
to the end ofdist_bins
array provided tobins_pairs_by_distance
and change this line in scaling.py frompairs_reduced_df["dist_bin_idx"] < len(dist_bins),
topairs_reduced_df["dist_bin_idx"] < len(dist_bins) - 1,
Thoughts? I'm happy to create a pull request with these changes.
The text was updated successfully, but these errors were encountered: