Looping a 4 bar clip skips the last bar

[alex-cherg]

Steps to reproduce:

• compile Luppp from 9986ec2
• record a clip lasting for 4 bars
• after the 4 bars the clip starts looping
• it goes successfully through 4 bars
• however, on the second "loop" after bar 3 it goes directly to bar 1
• the ultimate loop is 7 bars: b1 -> b2 -> b3 -> b4 -> b1 -> b2 -> b3 -> and repeat (b4 is skipped) -> b1 -> ...

Interestingly, when I save the session and then load it, the bug gets fixed and the full 4 bars loop correctly, however in a live performance scenario this is unfeasible.

I really like Luppp so far and would love to use it for live performances, however the above is a blocker.

Help is very much appreciated!

@harryhaaren

[alex-cherg]

I compiled from https://github.com/openAVproductions/openAV-Luppp/releases/tag/release-1.2.1 and the issue doesn't seem present. So this seems to be broken in one of the following commits: release-1.2.1...master

[harryhaaren]

Hmmm thanks for the breakdown into which range of commits are culprit, that is very helpful. I reviewed the commit messages, and didn't find an obvious culprit. Honestly, the fact there's no unit/integration tests built in Luppp (totally my lacking on doing this during development) allows this type of regression. As other comment I'm not really active on OpenAV projects anymore, so unless somebody picks up the issue & investigates, I'm not sure if/when it'll be fixed, sorry.