Fixed Feat: Implement Shimmer while user details are being loaded #2443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PratyushSingh07 pls review it |
PratyushSingh07
requested changes
Nov 20, 2023
app/src/main/java/org/mifos/mobile/ui/fragments/HomeOldFragment.kt
Outdated
Show resolved
Hide resolved
PratyushSingh07
requested changes
Nov 20, 2023
app/src/main/java/org/mifos/mobile/ui/fragments/HomeOldFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/mifos/mobile/ui/fragments/RecentTransactionsFragment.kt
Outdated
Show resolved
Hide resolved
kmanikanta335
force-pushed
the
patch4
branch
from
7cd05d4
to
21512da
Compare
|
make sure to change the commit message @kmanikanta335 |
|
@PratyushSingh07 what should I change it to |
just follow the guidelines |
|
@PratyushSingh07 when will it gets merged |
You still haven't followed the commit guidelines. It will be merged only after the admins approval |
Feat openMF#2412: Implement Shimmer while user details are being loaded Feat openMF#2412: Implement Shimmer while user details are being loaded Feat openMF#2412: Implement Shimmer while user details are being loaded Feat openMF#2412: Implement Shimmer while user details are being loaded
kmanikanta335
force-pushed
the
patch4
branch
from
21512da
to
2f4d461
Compare
|
@PratyushSingh07 i hope now its fine |
|
Please resolve the conflicts. |
|
@therajanmaurya i hope now it fine |
PratyushSingh07
requested changes
Jan 2, 2024
|
@kmanikanta335 squash your commits and make sure that your final commit follow contribution guidelines . I am again converting it to draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2412
Screenshots of UI changes.
2214.mp4
shimmerEffect.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
✅ Apply the
AndroidStyle.xmlstyle template to your code in Android Studio.✅ Run the unit tests with
./gradlew checkto make sure you didn't break anything✅ If you have multiple commits please combine them into one commit by squashing them.