Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix#2589: Migrate QrCodeReaderFragment from XML to compose #2590

Closed
wants to merge 1 commit into from

Conversation

itsPronay
Copy link
Contributor

@itsPronay itsPronay commented May 17, 2024

fixes #2589

Screencast_05_17_2024_03.42.28_PM.webm

 fix#2589: refactor: Migrate QrCodeReaderFragment from XML to compose

     fix#2589: refactor: Migrate QrCodeReaderFragment from XML to compose

fix#2589: refactor: Migrate QrCodeReaderFragment from XML to compose

fix#2589: refactor: Migrate QrCodeReaderFragment from XML to compose
.fillMaxSize()
.padding(it),
) {
AndroidView({ scannerView })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont we have any other options than AndroidView?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Unfortunately, as of now, there's no direct replacement in Jetpack Compose for ZXingScannerView that doesn't use AndroidView."

I looked up online and it was the only way I found. Probably we don't have another way of doing it.

@itsPronay itsPronay marked this pull request as draft May 20, 2024 13:11
@itsPronay itsPronay closed this Jun 3, 2024
@itsPronay itsPronay deleted the qrCodeFragmentMig branch June 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Migrate QrCodeReaderFragment from XML to compose
2 participants