-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15 incorporate asam osi utilities #16
Conversation
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
When I don't define the file_format in my ssp, it throws an error: Unknown trace file format |
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the default setting for compression in the mcap format?
Zstd with a "default" compression level. That is all part of the MCAP API default inits: https://mcap.dev/docs/cpp/r832FE362A16BB6E8 |
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
…L/sl-5-6-osi-trace-file-writer into 15-incorporate-asam-osi-utilities
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: Timm Ruppert <timm.ruppert@persival.de>
Signed-off-by: ClemensLinnhoff <clemens.linnhoff@persival.de>
Cpp-Linter Report
|
Reference to a related issue in the repository
Closes #15
Add a description
Use asam-osi-utilities to support writing to mcap, osi and txth trace files.
std::function
.actions/checkout
in recentv4
Note: I had also the idea to write the message without deserializing and implement something like a
writeSerializedMessage
into asam-osi-utilities but we need the timestamps for the MCAP anyways.Why this should be kept in draft for now:
osi_version
andprotobuf_version
fields of channel metadata. The automatic setting was intended as comfort function but it should if those fields are already present.Take this checklist as orientation for yourself, if this PR is ready for Maintainer Review