Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++20 future improvement #106

Open
pvmm opened this issue Mar 30, 2022 · 0 comments
Open

C++20 future improvement #106

pvmm opened this issue Mar 30, 2022 · 0 comments

Comments

@pvmm
Copy link
Contributor

pvmm commented Mar 30, 2022

I was going to suggest to replace this loop with a call to
std::erase_if(m, [](auto& entry) { return entry->index == -1; });
But this doesn't work (yet) because:

  • std::erase_if() is only available in c++20
  • it works on STL containers, but not on QMap. Any reason why you've chosen QMap instead of std::map?

So no need to change anything (yet).

Originally posted by @m9710797 in #104 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant