You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Right now, the method check_for_branch_request only supports the opened GitHub action. Since we don't do anything with the value of the GitHub action, it could be anything and it would still be fine. My proposal is to only check if the action key is present the _branch_request file, not for its value. This way, we can still tell apart GitHub and GitLab based on the presence or not of the action and object_kind in the _branch_request file.
The text was updated successfully, but these errors were encountered:
My suggestion would be to not rely on the payload from github/gitlab at all for this inside the service. We abstract this in the frontend or other clients. So _branch_request can just be some simple json file like
Right now, the method
check_for_branch_request
only supports theopened
GitHub action. Since we don't do anything with the value of the GitHub action, it could be anything and it would still be fine. My proposal is to only check if theaction
key is present the_branch_request
file, not for its value. This way, we can still tell apart GitHub and GitLab based on the presence or not of theaction
andobject_kind
in the_branch_request
file.The text was updated successfully, but these errors were encountered: