Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control characters in commit messages are written to .changes file #428

Open
martinkunkel2 opened this issue Sep 20, 2021 · 0 comments
Open

Comments

@martinkunkel2
Copy link

I used the obs_scm service on a git repo that contained a (non-newline) control character in a commit message.
This control character was copied to the my-package.changes file.
Building the package in our private open build service worked fine. No error was reported.

But when trying to install the package, it was not found and I discovered the problem:
[ 44s] C_CREATEREPOLIB: Critical: Cannot dump XML for my-package (9d062c...): Forbidden control chars found (ASCII values <32 except 9, 10 and 13).

Question: is that something which we should handle in obs_scm?

If yes, we could avoid writing control characters to the .changes file. I would try to add a pull request for this, but need a bit of guidance at which place this shall be fixed:

  • when reading the commit messages?
  • when writing the .changes file?
  • somewhere in between?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant