Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

history in request show lacks information which review was accepted #1636

Open
dmach opened this issue Oct 8, 2024 · 0 comments
Open

history in request show lacks information which review was accepted #1636

dmach opened this issue Oct 8, 2024 · 0 comments
Labels

Comments

@dmach
Copy link
Contributor

dmach commented Oct 8, 2024

osc suffers from a similar issue as OBS front-end: openSUSE/open-build-service#16926

$ osc rq show 1205594

...
History:
  2024-10-04T08:29:52 dimstar                        Review got accepted
...

Relevant part of the request XML data:

$ osc api /request/1205594
...
  <review state="accepted" when="2024-10-04T08:29:52" who="dimstar" by_group="opensuse-review-team">
    <comment/>
    <history who="dimstar" when="2024-10-04T08:29:52">
      <description>Review got accepted</description>
    </history>
  </review>

The by_group information should be part of the output so it's clear that the review was accepted on behalf of opensuse-review-team group.

@dmach dmach added the Bug label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant