You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Didn't want to make a PR with this after reading the contribution guidelines so I open an issue first to avoid violating those.
The 1-click install button can cause quite some issues on systems by adding repos that are not required or adding a repo that is already present or adding the wrong repo. I can't fix the behavior, but I think I was able to hide the button until someone comes along who has the knowledge I lack: https://github.com/apinter/software-o-o/tree/1-click-hide. My goal is to not cause issues to users who use this method to install a package from OBS.
I simply commented out the button in app/views/package/_download_rows.html.erb, which hopefully does the trick, but I have less than limited knowledge of Ruby dev.
Disclaimer 1: I don't have an OBS API key so I couldn't visually clarify that this actually works nice, and can only rely the unit tests below.
Disclaimer 2: Again, I have no idea what am I doing, but eager to help. Dangerous combo so.. Don't hold back ^_^
Test results:
--- git/1-click-remove ‹1-click-hide› » bundle exec rails test
WARNING: `Faraday::Connection#basic_auth` is deprecated; it will be removed in version 2.0.
While initializing your connection, use `#request(:basic_auth, ...)` instead.
See https://lostisland.github.io/faraday/middleware/authentication for more usage info.
Run options: --seed 2823
# Running:
....................
Finished in 6.668573s, 2.9991 runs/s, 7.7978 assertions/s.
20 runs, 52 assertions, 0 failures, 0 errors, 0 skips
Had some issues here, and also the link to FF headless mode is not loading the desired content:
Hi,
Didn't want to make a PR with this after reading the contribution guidelines so I open an issue first to avoid violating those.
The 1-click install button can cause quite some issues on systems by adding repos that are not required or adding a repo that is already present or adding the wrong repo. I can't fix the behavior, but I think I was able to hide the button until someone comes along who has the knowledge I lack: https://github.com/apinter/software-o-o/tree/1-click-hide. My goal is to not cause issues to users who use this method to install a package from OBS.
I simply commented out the button in
app/views/package/_download_rows.html.erb
, which hopefully does the trick, but I have less than limited knowledge of Ruby dev.Disclaimer 1: I don't have an OBS API key so I couldn't visually clarify that this actually works nice, and can only rely the unit tests below.
Disclaimer 2: Again, I have no idea what am I doing, but eager to help. Dangerous combo so.. Don't hold back ^_^
Test results:
Had some issues here, and also the link to FF headless mode is not loading the desired content:
The text was updated successfully, but these errors were encountered: