You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Much of the Broker Microservice-specific logic was abstracted in order to do this, but the code is still coupled in some places. Ideally, this should all be removed.
Impact
I believe that Harvesting Utils cannot move to v1 until this is resolved
Issues
Some known issues (some were spawned from this comment):
Remove the need for state.feedContextMap
Move the Duplicate feed identifier not permitted within dataset distribution check to Broker
I'm not fully sure I understand the reason for the feedContextMap.delete(..) logic when a 404 is reached. But we could instead employ a callback like onFeed404Error(..), where Broker would put its feedContextMap.delete(..)
Remove the need for state.startTime
startTime looks like it's just used when the last page is reached. So this could just be replaced with an onLastPage(..) callback, and Broker could do its own wrangling.
Remove the need for state.context
This is a bit more complicated of course!
Remove the need for multibar
This assumes that Harvesting Utils users will be:
Creating a progress bar
Creating that progress bar with the multibar library
Instead, there should be some way of reporting progress that Broker can tap into, such that only Broker manages multibar and other means for reporting that progress (e.g. with a different library or simpler logging) can tap into this.
Remove the reference to FatalError
See the code comment next to the check for "FatalError"
The text was updated successfully, but these errors were encountered:
// TODO: To prevent extraneous output, ensure that multibar.stop is only called if the multibar is already active (e.g. by wrapping the multibar to allow us to set it to null when not in use)
Harvesting Utils was originally moved from Broker Microservice.
Much of the Broker Microservice-specific logic was abstracted in order to do this, but the code is still coupled in some places. Ideally, this should all be removed.
Impact
I believe that Harvesting Utils cannot move to v1 until this is resolved
Issues
Some known issues (some were spawned from this comment):
Remove the need for state.feedContextMap
Duplicate feed identifier not permitted within dataset distribution
check to BrokeronFeed404Error(..)
, where Broker would put its feedContextMap.delete(..)Remove the need for state.startTime
startTime looks like it's just used when the last page is reached. So this could just be replaced with an
onLastPage(..)
callback, and Broker could do its own wrangling.Remove the need for state.context
This is a bit more complicated of course!
Remove the need for
multibar
This assumes that Harvesting Utils users will be:
multibar
libraryInstead, there should be some way of reporting progress that Broker can tap into, such that only Broker manages multibar and other means for reporting that progress (e.g. with a different library or simpler logging) can tap into this.
Remove the reference to
FatalError
See the code comment next to the check for "FatalError"
The text was updated successfully, but these errors were encountered: