fix(client): correctly handle errors during streaming

[stainless-bot]

No description provided.

[athyuttamre]

Looks like we're not setting the APIError.message here, is that intentional?

[RobertCraigie]

Yes, I was under the impression that the API error data will include a message property. That property will then be used by the APIError class if a message isn't explicitly passed in the constructor. If the message property isn't set, then we'll default to stringifying the error object to raw JSON.

Is that assumption correct?

[athyuttamre]

The assumption is correct, but I don't see code in APIError to assign message from the error object:

openai-node/src/error.ts

Lines 16 to 41 in 6484039

	constructor(
	status: number | undefined,
	error: Object | undefined,
	message: string | undefined,
	headers: Headers | undefined,
	) {
	super(`${status} ${APIError.makeMessage(error, message)}`);
	this.status = status;
	this.headers = headers;
	const data = error as Record<string, any>;
	this.error = data;
	this.code = data?.['code'];
	this.param = data?.['param'];
	this.type = data?.['type'];
	}
	private static makeMessage(error: any, message: string | undefined) {
	return (
	error?.message ?
	typeof error.message === 'string' ? error.message
	: JSON.stringify(error.message)
	: error ? JSON.stringify(error)
	: message || 'status code (no body)'
	);
	}

[RobertCraigie]

It's this line

openai-node/src/error.ts

Line 36 in 6484039

typeof error.message === 'string' ? error.message

The error argument there is the data that the API responded with

[athyuttamre]

Ah I see, thanks!

When status is undefined, should we skip the space in the error message here?

openai-node/src/error.ts

Line 22 in 6484039

super(`${status} ${APIError.makeMessage(error, message)}`);

[rattrayalex]

Yeah we can probably clean that up; I'll file a ticket