Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(azure): refresh auth token during retries #1533

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

RobertCraigie
Copy link
Collaborator

Original PR: #1531

This builds on Krista's PR & restructures the fix slightly so that we only refresh the token if the Authorization header wasn't explicitly given by the user.

Additional context & links

#1526

@RobertCraigie RobertCraigie requested a review from a team as a code owner July 9, 2024 13:58
@RobertCraigie
Copy link
Collaborator Author

cc @kristapratico, I can't seem to request a review

Copy link
Contributor

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better strategy, thanks @RobertCraigie! I've verified the change on my end and all looks good 👍

@stainless-bot stainless-bot force-pushed the robert/fix-azure-token-refresh branch from e5341d7 to ef58b3f Compare July 9, 2024 18:03
@RobertCraigie RobertCraigie merged commit 287926e into next Jul 9, 2024
@RobertCraigie RobertCraigie deleted the robert/fix-azure-token-refresh branch July 9, 2024 18:03
@stainless-app stainless-app bot mentioned this pull request Jul 9, 2024
megamanics pushed a commit to devops-testbed/openai-python that referenced this pull request Aug 14, 2024
cgayapr pushed a commit to cgayapr/openai-python that referenced this pull request Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants