Skip to content

fix(client): accidental blocking sleep in async code #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

fix(client): accidental blocking sleep in async code #1415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/openai/resources/beta/threads/runs/runs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

from __future__ import annotations

import time
import typing_extensions
from typing import Union, Iterable, Optional, overload
from functools import partial
Expand Down Expand Up @@ -1105,7 +1104,7 @@ def poll(
else:
poll_interval_ms = 1000

time.sleep(poll_interval_ms / 1000)
self._sleep(poll_interval_ms / 1000)

@overload
def stream(
Expand Down Expand Up @@ -2639,7 +2638,7 @@ async def poll(
else:
poll_interval_ms = 1000

time.sleep(poll_interval_ms / 1000)
await self._sleep(poll_interval_ms / 1000)

@overload
def stream(
Expand Down