Accepting PRs for openapi-typescript 5.x? #1505
mitchell-merry
started this conversation in
General
Replies: 1 comment
-
Sure! As long as it doesn’t break existing behavior, I’d be happy to accept any additions to previous versions. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi @drwpow !
I am wondering if PRs are accepted for 5.x of
openapi-typescript
. We want to avoid forking if possible, and we have a specific requirement for this version (we are still on swagger 2, groan).It has to do with this issue: #1083. I want to add support for
x-nullable
generating| null
in types. There's a suggestion in that issue to use theformatter
option, but since theformatter
passes in the full schema object (and not the type thatopenapi-typescript
generates by default), I think it would require re-implementing that logic. I tried calling out to internal functions to get this done... and couldn't make it work.If I were to raise a PR to support this, behind a CLI flag, would it be accepted and released?
Thanks!
Beta Was this translation helpful? Give feedback.
All reactions