Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

MakeCoMaster fails, when master does not have any replication settings #788

Closed
ghost opened this issue Feb 1, 2019 · 1 comment · Fixed by #789
Closed

MakeCoMaster fails, when master does not have any replication settings #788

ghost opened this issue Feb 1, 2019 · 1 comment · Fixed by #789

Comments

@ghost
Copy link

ghost commented Feb 1, 2019

If master does not have replication settings, i.e. slave slave status is "Empty set", the attempt to make it as co-master with the slave fails with the error:

ChangeMasterTo: Cannot change master on: master1:3306 because replication is running

As far as I understand it fails in ChangeMasterCredentials function, checking whether replication is stopped or not:

	if !instance.ReplicationThreadsStopped() {
		return instance, fmt.Errorf("ChangeMasterTo: Cannot change master on: %+v because replication is running", *instanceKey)
	}

But replication is neither stopped nor running. I suppose, it is "ReplicationThreadStateNoThread".
PS: this is latest version 3.0.14 issue.

@shlomi-noach
Copy link
Collaborator

addressed by #789

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant