On latest build system-vpd.service is failing.

[ninadpalsule]

The service is failing with --driver option required. I am not sure why we need "--driver" option for system vpd as we are providing EEPROM file path.

root@p10bmc:~# systemctl status system-vpd.service -l
x system-vpd.service - System VPD Collection
Loaded: loaded (/usr/lib/systemd/system/system-vpd.service; enabled; preset: enabled)
Active: failed (Result: exit-code) since Tue 2023-06-06 19:47:22 UTC; 23s ago
Process: 1515 ExecStart=/usr/bin/env ibm-read-vpd --file /sys/bus/i2c/drivers/at24/8-0050/eeprom (code=exited, status=106)
Main PID: 1515 (code=exited, status=106)
CPU: 382ms

Jun 06 19:47:21 p10bmc systemd[1]: Starting System VPD Collection...
Jun 06 19:47:22 p10bmc ibm-vpd-parser[1515]: --driver is required
Jun 06 19:47:22 p10bmc ibm-vpd-parser[1515]: Run with --help for more information.
Jun 06 19:47:22 p10bmc systemd[1]: system-vpd.service: Main process exited, code=exited, status=106/n/a
Jun 06 19:47:22 p10bmc systemd[1]: system-vpd.service: Failed with result 'exit-code'.
Jun 06 19:47:22 p10bmc systemd[1]: Failed to start System VPD Collection.

I am wondering if this is caused by this change.

f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1389) // Check if input file is not empty.
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1390) if ((file.empty()) || (driver.empty()))
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1391) {
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1392) std::cerr << "Encountered empty input parameter file [" << file
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1393) << "] driver [" << driver << "]" << std::endl;
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1394) return 0;
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1395) }
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1396)
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1397) // Check if currently supported driver or not
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1398) if ((driver != at24driver) && (driver != at25driver) &&
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1399) (driver != ee1004driver))
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1400) {
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1401) std::cerr << "The driver [" << driver << "] is not supported."
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1402) << std::endl;
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1403) return 0;
f457a3ef (jinuthomas 2023-04-13 12:22:48 -0500 1404) }

[ninadpalsule]

Also the service file does not pass any driver. also running ibm-read-vpd command gives the same error.

[Service]
ExecStart=/usr/bin/env ibm-read-vpd --file /sys/bus/i2c/drivers/at24/8-0050/eeprom
SyslogIdentifier=ibm-vpd-parser

root@p10bmc:~# ibm-read-vpd --file /sys/bus/i2c/drivers/at24/8-0050/eeprom
--driver is required
Run with --help for more information.