Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkout issue still there! Is it a lost session issue? #345

Closed
mhcwebdesign opened this issue Jan 13, 2013 · 2 comments
Closed

Checkout issue still there! Is it a lost session issue? #345

mhcwebdesign opened this issue Jan 13, 2013 · 2 comments

Comments

@mhcwebdesign
Copy link
Collaborator

Hi Daniel,

See my new comment and added screenshots at #335 !

@mhcwebdesign
Copy link
Collaborator Author

OKI, I ran some further tests. The issue seems to be caused by the line:

        // Regenerate the session ID on each request so it can not be hijacked.
        session_regenerate_id();

in system/library/session.php. When I comment it out, the checkout works fine, no lost $this->data->session['payment_methods'] during the checkout. As soon as I allow session_regenerate_id() call in system/library/session.php, the checkout issue re-occurs!

Maybe session_regenerate_id() calls don't play nicely with all the Ajax calls during the checkout procedure?

@opencart
Copy link
Collaborator

i'm not sure it can be hijacked because this is how oscommerce and other systems have used sessions for years.

and those guys put the sessions in urls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant