New banner image sort order not displaying.

[bhavin30]

Notice: Undefined index: sort_order in \opencart-2.1.0.1\upload\admin\controller\design\banner.php on line 386
Save with out adding banner title and get notice.

[jremes-foss]

This is yet to be reproduced, but my main suspicion is that the code causing this to happen is this piece in admin/controller/design/banner.php:

            foreach ($banner_image_description_query->rows as $banner_image_description) {
                $banner_image_description_data[$banner_image_description['language_id']] = array('title' => $banner_image_description['title']);
            }

Basically, the foreach loop in question saves the title to array by default. If there is no title, the notice appears. I need to dig deeper and reproduce the bug later on.

[OpenCartAddons]

This was caused due to a missing double quote in the banner_form.tpl. The fix is here #3399

Regards,
Joel.

[bhavin30]

thank you :)