Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation in Order Information page is broken (v 2.0.3.1) #3575

Closed
andreihq opened this issue Oct 29, 2015 · 2 comments
Closed

Localisation in Order Information page is broken (v 2.0.3.1) #3575

andreihq opened this issue Oct 29, 2015 · 2 comments

Comments

@andreihq
Copy link

When new order is created, it looks like OpenCart saves title strings for the following entities in DB for each order:

  • shipping method
  • payment method
  • product name
  • total modules

That means that if user ordered something while using language A, these strings are saved using this language. If user then switches to language B and goes to view Order Details, she will see strings from language A.

Is there a particular reason why OpenCart saves these strings? I can only think that so not to do few extra joins to get the proper values from relevant tables, but I don't think its worth it and it affects user experience negatively.

@andreihq andreihq changed the title Localisation in Order Information Page is broken (v 2.0.3.1) Localisation in Order Information page is broken (v 2.0.3.1) Oct 29, 2015
@andreihq
Copy link
Author

Further investigation showed that actually there is no way to get strings for payment, shipping and total modules without actually requesting the module or using them.

Payment Modules have only method getMethod()
Shipping Modules have only method getQuote()
Order Total Modules have only method getTotal()

I think these modules should have another method, like getInfo() that returns common information about the module, i.e. its title using current session language.

@andreihq
Copy link
Author

Daniel,
Why you decided to close this? Is it fixed in version 2.1.0.1 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants