Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test deployment dependent on developer membership #488

Open
lkiesow opened this issue May 28, 2024 · 0 comments
Open

Make test deployment dependent on developer membership #488

lkiesow opened this issue May 28, 2024 · 0 comments
Labels
type:infrastructure Build process, deployment, workflows

Comments

@lkiesow
Copy link
Member

lkiesow commented May 28, 2024

For improved security, we should make the test deployments (container and GitHub Pages) introduced in #470 and #472 dependent on the pull request author being a member of the group “Developers” in the GitHub organization Opencast.

For more details, take a look at how this is done for the Opencast Editor:
https://github.com/opencast/opencast-editor/blob/f7227d2b58a79279bd4fc67a98007fd352c294a4/.github/workflows/update-test.yml#L105-L132
@ziegenberg ziegenberg added the type:infrastructure Build process, deployment, workflows label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:infrastructure Build process, deployment, workflows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ziegenberg @lkiesow