Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the "scrubber" a scissor and allow quick cutting #1134

Open
oas777 opened this issue Aug 18, 2023 · 4 comments
Open

Make the "scrubber" a scissor and allow quick cutting #1134

oas777 opened this issue Aug 18, 2023 · 4 comments

Comments

@oas777
Copy link

oas777 commented Aug 18, 2023

grafik

You know, like the other editor:

Bildschirmfoto_2023-08-18_um_14 40 09

@oas777
Copy link
Author

oas777 commented Sep 8, 2023

To be discussed: Is this more efficient? Or should video editors use the keyboard shortcuts?

@Arnei
Copy link
Member

Arnei commented Sep 8, 2023

Personally, I'm not a fan of this hover button solution. Hover elements inadvertently cover other elements and require rules for appearance/disappearance that are often unintuitive to users. Also we'd have two cutting buttons which could be confusing.

As I understand it, this solution intends to allow for quick cutting after you moved the playhead, as the distance between playhead and the hover button is minimal. Unlike the regular cutting button, which tends to be far enough away to significantly increase the time it takes to reach it, resulting in bad UX.

I think keyboard shortcuts are the perfect solution for this. Especially if you work with the editor a lot they should be at least as fast if not faster than the hover button solution. (I also agree that the current keyboard shortcuts are ..unwieldy to say the least, but that's a topic for another issue).

@ziegenberg
Copy link
Member

I second what @Arnei says.

@lkiesow
Copy link
Member

lkiesow commented Feb 27, 2024

We discussed this as part of the crowdfunding sprint kickoff. We didn't include it in the sprint for the following reasons (@kai-wng-uos, can you check if I remembered everything correctly?):

  • We agreed with @Arnei that shortcuts are more helpful for advanced users
  • We agreed with @Arnei that having several buttons that do the same thing is not good. We would like to avoid confusion and clutter.
  • We see additional complications when editing on tablets (and maybe in the future on mobile devices) since
    • …it would need to be a relatively small control element
    • …you could easily trigger that element when using the scrubber since you are less precise with your fingers

We left this in the category needing further discussion mainly for two reasons:

  • We may want to highlight the keyboard shortcut better (we want to take another look if the current situation is okay)
  • We may want to look into implementing something similar to Add right click menu for cutting #943 for cutting as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: To be discussed
Development

No branches or pull requests

4 participants