Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sun position dependnce on pv data #67

Open
AUdaltsova opened this issue Oct 15, 2024 · 0 comments
Open

remove sun position dependnce on pv data #67

AUdaltsova opened this issue Oct 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AUdaltsova
Copy link
Contributor

AUdaltsova commented Oct 15, 2024

Sun position currently lifts time off of pv data's forecast_minutes, it should instead generate the time series based off of pv's t0 and time resolution. This is needed for example to correctly run site backtest script, as currently it runs into problems at the tail end when it starts running out of pv data to have the right number of points in forecast part, and sun position ends up being the wrong shape.

This should be done for all targets, not just pv

It's not a major problem as currently this never happens in batch creation and in prod apps (as far as I know) handle that instead of datapipes, but i think it would be better for datasampler to do it robustly instead of apps doing it with hardcoded time settings. Also creates less work moving forward adding new models to apps, but might be a bit of a rehaul to get it working and remove current hack-arounds

@AUdaltsova AUdaltsova transferred this issue from openclimatefix/ocf_datapipes Oct 18, 2024
@AUdaltsova AUdaltsova added the enhancement New feature or request label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant