Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

function to => #435

Closed
matteofigus opened this issue Apr 4, 2017 · 5 comments
Closed

function to => #435

matteofigus opened this issue Apr 4, 2017 · 5 comments

Comments

@matteofigus
Copy link
Member

matteofigus commented Apr 4, 2017

A non critical optimisation that would be ideal for a first time contribution to OC.

Edit: Before proceding, can you please vote with 👍 or 👎

@mattiaerre
Copy link
Member

I like arrow functions but I think this issue should be tagged as discussion as well; unlike const/let there is no general agreement whether to use arrow functions or not.

@nickbalestra
Copy link
Contributor

💯 x 💯 🏹 for me!

@elboletaire
Copy link
Collaborator

elboletaire commented Apr 5, 2017

As said in #436, eslint may also help with that, at least for callback functions:

@matteofigus
Copy link
Member Author

I removed the discussion flag as it looks there are no objections on this. Do we have enough for proceeding with this? Specifically,

  1. All agree about the eslint rule?
  2. Anyone can/wants to work on this?

@elboletaire
Copy link
Collaborator

I want to work on this, but I'm out for two weeks, so I leave the door open for others.

I guess that client-side files should stay without arrow functions, like with #436, as there are some still used browsers that do not understand them (like IE 10...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants