Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct version in saithrift package #1869

Open
kcudnik opened this issue Aug 29, 2023 · 3 comments
Open

Correct version in saithrift package #1869

kcudnik opened this issue Aug 29, 2023 · 3 comments
Assignees
Labels

Comments

@kcudnik
Copy link
Collaborator

kcudnik commented Aug 29, 2023

Is this correct version https://github.com/opencomputeproject/SAI/blob/master/test/saithriftv2/setup.py#L8 ? 0.9 ?
This is hard string, should that be version or thrift tool ?

# thrift --version
Thrift version 0.13.0

like 0.13.0 ? or this 0.9 is arbitrary and just represents real saithrift version ?

@kcudnik
Copy link
Collaborator Author

kcudnik commented Aug 29, 2023

also seems like all builds are using thrift verssion 0.11.0, which is like from 2007, and on http://archive.apache.org/dist/thrift/ there is this year newest version 0.18.1 2023, is there a reason for that ?

@kcudnik
Copy link
Collaborator Author

kcudnik commented Sep 8, 2023

@chrispsommers do you have maybe any idea here? and why we actually use thrift v0.11.0 instead of latest one which is like v0.19.0 ?

@chrispsommers
Copy link
Contributor

@kcudnik I have no idea, perhaps someone at Intel could weigh in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants